netdev - Re: [PATCH 2/2] ipv4: fix mss comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120228093426.GA17057@electric-eye.fr.zoreil.com>
Date:	Tue, 28 Feb 2012 10:34:26 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: fix mss comparison

roy.qing.li@...il.com <roy.qing.li@...il.com> :
[...]
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 0489ced..c72f765 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1914,8 +1914,8 @@ static unsigned int ipv4_default_advmss(const struct dst_entry *dst)
>  	if (advmss == 0) {
>  		advmss = max_t(unsigned int, dst->dev->mtu - 40,
>  			       ip_rt_min_advmss);
> -		if (advmss > 65535 - 40)
> -			advmss = 65535 - 40;
> +		if (advmss > 65535 - sizeof(struct tcphdr))
> +			advmss = 65535 - sizeof(struct tcphdr);

What would prevent net/ipv4/tcp_output.c::tcp_advertise_mss returning
a value beyond 65535 - 40 ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html