netdev - Re: [PATCH] tcp: fix comment for tp->highest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Feb 2012 16:38:24 -0800
From:	Yuchung Cheng <ycheng@...gle.com>
To:	Neal Cardwell <ncardwell@...gle.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	ilpo.jarvinen@...sinki.fi, Nandita Dukkipati <nanditad@...gle.com>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH] tcp: fix comment for tp->highest_sack

On Mon, Feb 27, 2012 at 2:51 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
> There was an off-by-one error in the comments describing the
> highest_sack field in struct tcp_sock. The comments previously claimed
> that it was the "start sequence of the highest skb with SACKed
> bit". This commit fixes the comments to note that it is the "start
> sequence of the skb just *after* the highest skb with SACKed bit".
>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> ---
>  include/linux/tcp.h |    3 ++-
>  include/net/tcp.h   |    5 +++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index 46a85c9..3c7ffdb 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -412,7 +412,8 @@ struct tcp_sock {
>
>        struct tcp_sack_block recv_sack_cache[4];
>
> -       struct sk_buff *highest_sack;   /* highest skb with SACK received
> +       struct sk_buff *highest_sack;   /* skb just after the highest
> +                                        * skb with SACKed bit set
>                                         * (validity guaranteed only if
>                                         * sacked_out > 0)
>                                         */
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index 42c29bf..2d80c29 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -1364,8 +1364,9 @@ static inline void tcp_push_pending_frames(struct sock *sk)
>        }
>  }
>
> -/* Start sequence of the highest skb with SACKed bit, valid only if
> - * sacked > 0 or when the caller has ensured validity by itself.
> +/* Start sequence of the skb just after the highest skb with SACKed
> + * bit, valid only if sacked_out > 0 or when the caller has ensured
> + * validity by itself.
>  */
>  static inline u32 tcp_highest_sack_seq(struct tcp_sock *tp)
>  {
> --
> 1.7.7.3
>
Acked-by: Yuchung Cheng <ycheng@...gle.com>

AFAICT, highest_sack_* in Linux are essentially SND.FACK? if so it
would be nice to add that in the comment too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html