netdev - Re: [PATCH] tcp: fix tcp_shifted_skb() adjustment of lost_cnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120227.233105.919773668237455042.davem@davemloft.net>
Date:	Mon, 27 Feb 2012 23:31:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	ilpo.jarvinen@...sinki.fi, gregkh@...uxfoundation.org,
	netdev@...r.kernel.org, nanditad@...gle.com, ycheng@...gle.com,
	therbert@...gle.com, subramanian.vijay@...il.com
Subject: Re: [PATCH] tcp: fix tcp_shifted_skb() adjustment of lost_cnt_hint
 for FACK

From: Neal Cardwell <ncardwell@...gle.com>
Date: Mon, 27 Feb 2012 22:45:31 -0500

> On Mon, Feb 27, 2012 at 9:58 PM, David Miller <davem@...emloft.net> wrote:
>> From: Neal Cardwell <ncardwell@...gle.com>
>> Date: Mon, 27 Feb 2012 21:40:03 -0500
>>
>>> Yes, I agree that it would make sense to hold off on adding these
>>> three 3.3-rc4 commits to the stable tree:
>>>
>>> cc9a672ee522d4805495b98680f4a3db5d0a0af9
>>>
>>> daef52bab1fd26e24e8e9578f8fb33ba1d0cb412
>>>
>>> 0af2a0d0576205dda778d25c6c344fc6508fc81d
>>>
>>> It would make sense to let the dust settle a bit more before adding
>>> those to the stable tree.
>>>
>>> The same goes for the http://patchwork.ozlabs.org/patch/143114/ patch
>>> (under review) that is in the same area of the code.
>>
>> I totally disagree and I have submitted those fixes to -stable
>> already and do not plan to rescind those submissions at all.
> 
> OK, sounds good to me. In that case I think it would be good to have
> the http://patchwork.ozlabs.org/patch/143114/ patch in -stable as
> well, since having just the three patches above would leave us with a
> known reordering issue.

I'll make sure it hits the -stable release after the one Greg is
trying to put out right now.

The change you reference rarely matters as most of the time it passes
a degreee of reordering of one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html