netdev - Re: [PATCH 03/13] mac802154: RX data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120228.152213.1300224068127558485.davem@davemloft.net>
Date:	Tue, 28 Feb 2012 15:22:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net,
	dbaryshkov@...il.com
Subject: Re: [PATCH 03/13] mac802154: RX data path

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Tue, 28 Feb 2012 18:00:22 +0300

> Main RX data path implementation between physical and mac layers.
> Both contexts are supported: interrupt (data processed via worker)
> and non-interrupt (data processed directly).
> 
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@...il.com>

If packets are properly pushed into the stack via the core receive
packet processing of the networking, you should always be in softirq
context and therefore have no need to a workqueue to get out of hardirq
context.

Please redo this code so that it processes RX packets properly and
consistently with how other protocol layers do things, which is taking
packets from the netif_receive_skb() et al. paths via core protocol
demux and therefore running always in softirq context.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html