netdev - Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120228.160720.990486775074267929.davem@davemloft.net>
Date:	Tue, 28 Feb 2012 16:07:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	James.Bottomley@...senPartnership.com, rjw@...k.pl,
	linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
	maciej.rutecki@...il.com, florian@...kler.org, mchan@...adcom.com,
	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in
 shutdown) on 3.3-rc1

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Mon, 27 Feb 2012 17:24:08 -0800

> On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote:
>> On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote:
>> > This message has been generated automatically as a part of a summary report
>> > of recent regressions.
>> > 
>> > The following bug entry is on the current list of known regressions
>> > from 3.2.  Please verify if it still should be listed and let the tracking team
>> > know (either way).
>> > 
>> > 
>> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=42707
>> > Subject		: Hang deconfiguring network interface (in shutdown) on 3.3-rc1
>> > Submitter	: James Bottomley <James.Bottomley@...senpartnership.com>
>> > Date		: 2012-01-28 19:56 (27 days old)
>> > Message-ID	: <1327780565.2924.24.camel@...dike.int.hansenpartnership.com>
>> > References	: http://marc.info/?l=linux-kernel&m=132778076214873&w=2
>> 
>> Still present in 3.3-rc4; I've bisected it back to this commit:
>> 
>> commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1
>> Author: Matt Carlson <mcarlson@...adcom.com>
>> Date:   Thu Dec 8 14:40:14 2011 +0000
>> 
>>     tg3: Save stats across chip resets
>> 
>> and sure enough, just reverting this single commit on 3.3-rc4 fixes the
>> problem.
>> 
>> James
> 
> I don't see anything incorrect about the patch.  I'm guessing the patch
> just changes the timing somehow.
> 
> tg3_reset_chip() does not take any driver-internal spinlocks.  That
> happens at tg3_close().  I'm guessing the spinlock in the trace is coming
> from synchronize_irq().

If you can't figure it out, we need to revert, so send me a revert patch
as soon as possible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html