netdev - Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Feb 2012 21:04:07 -0800
From:	Joe Perches <joe@...ches.com>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

On Wed, 2012-02-29 at 10:15 +0530, Mugunthan V N wrote:
> This patch adds support for TI's CPSW driver.
[]
> +static int cpsw_poll(struct napi_struct *napi, int budget)
> +{
> +	struct cpsw_priv	*priv = napi_to_priv(napi);
> +	int			num_tx, num_rx;
> +
> +	num_tx = cpdma_chan_process(priv->txch, 128);
> +	num_rx = cpdma_chan_process(priv->rxch, budget);
> +
> +	if (num_rx || num_tx)
> +		cpsw_dbg(priv, intr, pr_fmt("poll %d rx, %d tx pkts"),
> +			  num_rx, num_tx);

You don't need pr_fmt() for any of these cpsw_<level> uses.
but you do need a terminating "\n".

> +static int __devinit cpsw_probe(struct platform_device *pdev)
[]
> +	if (!data) {
> +		pr_err("cpsw: platform data missing\n");

Don't need "cpsw: " prefix


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html