lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201202290822.59640.danny.kukawka@bisect.de> Date: Wed, 29 Feb 2012 08:22:58 +0100 From: Danny Kukawka <danny.kukawka@...ect.de> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: David Miller <davem@...emloft.net>, jeffrey.t.kirsher@...el.com, jpirko@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier On Dienstag, 28. Februar 2012, Geert Uytterhoeven wrote: > Hi David, > > 2012/2/28 David Miller <davem@...emloft.net>: > > From: Geert Uytterhoeven <geert@...ux-m68k.org> > > Date: Tue, 28 Feb 2012 21:45:30 +0100 > > > >> drivers/net/ethernet/cirrus/mac89x0.c: In function ‘set_mac_address’: > >> drivers/net/ethernet/cirrus/mac89x0.c:597: warning: dereferencing > >> ‘void *’ pointer > >> drivers/net/ethernet/cirrus/mac89x0.c:597: error: request for member > >> ‘sa_data’ in something not a structure or union > >> drivers/net/ethernet/cirrus/mac89x0.c:600: warning: dereferencing > >> ‘void *’ pointer > >> drivers/net/ethernet/cirrus/mac89x0.c:600: error: request for member > >> ‘sa_data’ in something not a structure or union > >> drivers/net/ethernet/cirrus/mac89x0.c:595: warning: unused variable > >> ‘saddr’ > > > > Thanks, I've fixed this as follows and pushed to net-next: > > > > -------------------- > > mac89x0: Fix build error. > > > > Need to use the new 'saddr' variable not the void 'addr' in > > set_mac_address(). > > > > Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org> > > Signed-off-by: David S. Miller <davem@...emloft.net> Thanks for the fix! > Thanks, that fixed the build. > > What about the is_valid_ether_addr() check? If you mean the discussion about checking if the MAC is valid in .ndo_set_mac_address, I'm on that issue and will hopefully send a patch soon. Danny -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists