netdev - Re: [PATCH 0/8] validate MAC address before call .ndo_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330531139.8460.192.camel@deadeye>
Date:	Wed, 29 Feb 2012 15:58:59 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Danny Kukawka <danny.kukawka@...ect.de>
CC:	"David S. Miller" <davem@...emloft.net>,
	Eilon Greenstein <eilong@...adcom.com>,
	Jon Mason <jdmason@...zu.us>, Danny Kukawka <dkukawka@...e.de>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Florian Fainelli <florian@...nwrt.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Javier Martinez Canillas <martinez.javier@...il.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jiri Kosina <jkosina@...e.cz>, Jiri Pirko <jpirko@...hat.com>,
	Joe Perches <joe@...ches.com>,
	John Crispin <blogic@...nwrt.org>,
	<linux-kernel@...r.kernel.org>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Michał Mirosław <mirq-linux@...e.qmqm.pl>,
	Neil Horman <nhorman@...driver.com>, <netdev@...r.kernel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH 0/8] validate MAC address before call
 .ndo_set_mac_address

On Wed, 2012-02-29 at 16:42 +0100, Danny Kukawka wrote:
> Validate the given MAC address directly in dev_set_mac_address()
> if a .ndo_validate_addr function is available before calling
> the .ndo_set_mac_address function.
> 
> Changed .ndo_validate_addr to take a second parameter containing
> a sockaddr struct to be checked instead of the net_device dev_addr.
> The behaviour of .ndo_validate_addr is now: if the second parameter
> is NULL the net_device->dev_addr gets validate, if != NULL
> the given parameter/sockaddr gets validated instead.
> 
> This patch series include adaptations for some drivers which
> use .ndo_set_mac_address functions directly - to prevent double
> checks and to enable validations via .ndo_validate_addr.
[...]

You have to do this as a single patch.  The kernel and drivers should
still build at each stage.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html