netdev - RE: [PATCH] net: add QCA alx Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <157393863283F442885425D2C4542856194154FC@nasanexd02a.na.qualcomm.com>
Date:	Wed, 29 Feb 2012 02:19:05 +0000
From:	"Huang, Xiong" <xiong@....qualcomm.com>
To:	"Rodriguez, Luis" <rodrigue@....qualcomm.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-linux-team <qca-linux-team@...lcomm.com>,
	nic-devel <nic-devel@...lcomm.com>,
	"Giori, Kathy" <kgiori@....qualcomm.com>,
	"chris.snook@...il.com" <chris.snook@...il.com>,
	"Olivari, Mathieu" <mathieu@....qualcomm.com>,
	"Huntsman, Bryan" <bryanh@...cinc.com>
Subject: RE: [PATCH] net: add QCA alx Ethernet driver

Hi David
     The code related to hardware of atl1c is quite diff with that in our hand, every time we take much time to find which part should be 
revised for one bug/issue found on other platform/OSes. the new driver make it easy to fix and support new chipset as well.

     We reviewed all patches that applied to atl1c and added it to the alx  during coding. And did tests for both new and old drivers
You could find the result here:  http://www.linuxfoundation.org/collaborate/workgroups/networking/alx


Best Regards
-Xiong

 -----Original Message-----
> From: mcgrof@...il.com [mailto:mcgrof@...il.com] On Behalf Of Luis R.
> Rodriguez
> Sent: Wednesday, February 29, 2012 10:13
> To: David Miller
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; qca-linux-team; nic-
> devel; Giori, Kathy; chris.snook@...il.com; Olivari, Mathieu; Huntsman, Bryan
> Subject: Re: [PATCH] net: add QCA alx Ethernet driver
> 
> On Tue, Feb 28, 2012 at 5:53 PM, David Miller <davem@...emloft.net> wrote:
> > From: "Luis R. Rodriguez" <rodrigue@....qualcomm.com>
> > Date: Tue, 28 Feb 2012 17:50:09 -0800
> >
> >> The next patch adds the new QCA alx Ethernet driver that supercedes
> >> the atl1c Ethernet driver. For details please read the commit log of
> >> the patch. Given the size you can download the patch from:
> >
> > What's wrong with making evolutionary fixes to atl1c instead of
> > replacing it wholesale?
> >
> > This isn't the way to do it Luis.
> 
> I *vehemently* tried to change direction of this driver development to do
> exactly what you stated when this driver was first posted last year in October of
> 2011 [0]. I could not get commitment on that route mainly due to the large delta
> and lack of resources to address this. I knew this would still be a hard sale but
> what I proposed was a comprise --  consider a replacement *if* we can get QCA
> engineers tasked to work upstream and committed to fixing *all* issues
> reported,
> *and* also properly tested and compared drivers.
> 
> The other option we had reviewed here was to get this into staging but the
> garbage driver code is all resolved now. Its your call. This is the best I could get
> commitment and resources on.
> 
> [0] http://markmail.org/message/7dk7ltdcdlx5ksu6
> 
>   Luis