netdev - Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOD=uF4LSS8nuKMNHGEH2JsVZHU0rntSxZjvNaa4oZrey1macw@mail.gmail.com>
Date:	Thu, 1 Mar 2012 19:34:58 +0530
From:	santosh prasad nayak <santoshprasadnayak@...il.com>
To:	Andrei Emeltchenko <andrei.emeltchenko.news@...il.com>,
	santosh nayak <santoshprasadnayak@...il.com>,
	marcel@...tmann.org, padovan@...fusion.mobi, davem@...emloft.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.

Andrei,

I could not get you.

Do you want me to resend the patch with subject,
  "[PATCH] Bluetooth: Fix network to host endian conversion for L2CAP
chan id."  ?



regards
santosh




On Thu, Mar 1, 2012 at 6:05 PM, Andrei Emeltchenko
<andrei.emeltchenko.news@...il.com> wrote:
> Hi Santosh,
>
> On Thu, Mar 01, 2012 at 04:29:21PM +0530, santosh nayak wrote:
>> From: Santosh Nayak <santoshprasadnayak@...il.com>
>>
>> Fix for endian bug.
>>
>> Fix for null dereferenced removed as it is already
>> submitted by Andrei.
>>
>> Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com>
>> ---
>>  net/bluetooth/l2cap_sock.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> We prefer following commit log (this is the example)
>
> <------8<----------------------------------------------------------
> |  From: Santosh Nayak <santoshprasadnayak@...il.com>
> |
> |  Fix network to host endian conversion for L2CAP chan id.
> |
> |  Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com>
> |
> |  ---
> |          * v2 Fix for null dereferenced removed as it is already
> |          submitted by Andrei.
> |
> |    net/bluetooth/l2cap_sock.c |    5 +++--
> |    1 files changed, 3 insertions(+), 2 deletions(-)
> |
> <------8<----------------------------------------------------------
>
>
>>
>> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
>> index 401d942..86d5067 100644
>> --- a/net/bluetooth/l2cap_sock.c
>> +++ b/net/bluetooth/l2cap_sock.c
>> @@ -82,7 +82,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
>>       }
>>
>>       if (la.l2_cid)
>> -             err = l2cap_add_scid(chan, la.l2_cid);
>> +             err = l2cap_add_scid(chan, __le16_to_cpu(la.l2_cid));
>>       else
>>               err = l2cap_add_psm(chan, &la.l2_bdaddr, la.l2_psm);
>>
>> @@ -123,7 +123,8 @@ static int l2cap_sock_connect(struct socket *sock, struct sockaddr *addr, int al
>>       if (la.l2_cid && la.l2_psm)
>>               return -EINVAL;
>>
>> -     err = l2cap_chan_connect(chan, la.l2_psm, la.l2_cid, &la.l2_bdaddr);
>> +     err = l2cap_chan_connect(chan, la.l2_psm, __le16_to_cpu(la.l2_cid),
>> +                             &la.l2_bdaddr);
>
> I live this to Marcel to decide should we reindent our code otherwise this
> one looks odd.
>
> Best regards
> Andrei Emeltchenko
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html