netdev - Re: [Bridge] [PATCH 2/3] netfilter: potential null derefence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F513C2B.6030604@pandora.be>
Date:	Fri, 02 Mar 2012 22:31:23 +0100
From:	Bart De Schuymer <bdschuym@...dora.be>
To:	Pablo Neira Ayuso <pablo@...filter.org>
CC:	santosh nayak <santoshprasadnayak@...il.com>,
	netfilter@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net, bart.de.schuymer@...dora.be,
	netfilter-devel@...r.kernel.org, shemminger@...tta.com
Subject: Re: [Bridge] [PATCH 2/3] netfilter: potential null derefence.

Op 1/03/2012 13:30, Pablo Neira Ayuso schreef:
> On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
>> From: Santosh Nayak<santoshprasadnayak@...il.com>
>>
>> I am getting following error.
>> " net/bridge/netfilter/ebtables.c:269 ebt_do_table()
>>    error: potential null derefence 'cs'"
>>
>>      i = cs[sp].n;  // If cs == Null then this will cause problem.
>
> Very sorry, I didn't see the out label.
>
> I'll apply this to my nf [1] once David takes my previous request for
> pulling.
>

Hi,

Has this patch been tested? Really, that code in the core firewall 
function is there for a reason, wouldn't you think?
The chainstack is only allocated when user-defined chains are used (see 
translate_table).
Never blindly trust a tool.

Bart
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html