netdev - Re: [PATCH] Bluetooth: Silence static checker warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Mar 2012 14:04:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	santosh nayak <santoshprasadnayak@...il.com>,
	padovan@...fusion.mobi, davem@...emloft.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Ville Tervo <ville.tervo@...ia.com>
Subject: Re: [PATCH] Bluetooth: Silence static checker warning.

On Fri, Mar 02, 2012 at 09:15:37AM -0000, David Laight wrote:
> How long has this code been in tree?
> It isn't obvious to me that this change won't break code on BE systems
> where the application code is already fixing the endianness.
> 

It looks like we've had an endian bug since last February.

b62f328b8f20a "Bluetooth: Add server socket support for LE
connection"

+               l2cap_pi(sk)->scid = la.l2_cid;

->scid was cpu endian.

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)