netdev - Re: [PATCH] tcp: fix tcp_retransmit_skb() to maintain MSS invariant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Mar 2012 19:05:07 -0800
From:	Yuchung Cheng <ycheng@...gle.com>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Neal Cardwell <ncardwell@...gle.com>,
	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Nandita Dukkipati <nanditad@...gle.com>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH] tcp: fix tcp_retransmit_skb() to maintain MSS invariant

On Fri, Mar 2, 2012 at 12:25 PM, Ilpo Järvinen
<ilpo.jarvinen@...sinki.fi> wrote:
> Why would we be splitting SACKed segment there?!? ...Ah, it seems that
> it indeed is possible now after the non-FACK mode fragment, however, it
> is totally useless work and seems to be breaking stuff. I think that the
> proper solution is to prevent splitting of already SACKed stuff. ...Nice
> find btw. :-)

Bingo! I totally agree this is the bug. looks like a one-line patch now.

We _really_ need to refactor the cryptic tcp_mark_head_lost(). I have a patch
ready for review once the recent sack turmoil settles.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html