netdev - Re: [PATCH net-next] mlx4_en: dont change mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZKAwrx-u_onDQCCxipkLPdZkPE6cokRtZOa1uRZiZTYug@mail.gmail.com>
Date:	Sun, 4 Mar 2012 13:19:33 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Subject: Re: [PATCH net-next] mlx4_en: dont change mac_header on xmit

> +       ethh = (struct ethhdr *)skb->data;
> +       tx_desc->ctrl.srcrb_flags16[0] = get_unaligned((u16 *)ethh->h_dest);
> +       tx_desc->ctrl.imm = get_unaligned((u32 *)(ethh->h_dest + 2));

Hi Eric,

commit 622121719934f60378279eb440d3cec2fc3176d2 of your triggers the
below sparse
warnings, could you advise what would be the correct way to fix that out?

Or.

 CHECK   drivers/net/ethernet/mellanox/mlx4/en_tx.c
drivers/net/ethernet/mellanox/mlx4/en_tx.c:689:40: warning: incorrect
type in assignment (different base types)
drivers/net/ethernet/mellanox/mlx4/en_tx.c:689:40:    expected
restricted __be16 <noident>
drivers/net/ethernet/mellanox/mlx4/en_tx.c:689:40:    got unsigned
short [unsigned] <noident>
drivers/net/ethernet/mellanox/mlx4/en_tx.c:690:27: warning: incorrect
type in assignment (different base types)
drivers/net/ethernet/mellanox/mlx4/en_tx.c:690:27:    expected
restricted __be32 [usertype] imm
drivers/net/ethernet/mellanox/mlx4/en_tx.c:690:27:    got unsigned int
[unsigned] <noident>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html