netdev - Re: [PATCH v4] ipv6: Fix problem with expired dst cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120305.000558.923755086046890012.davem@davemloft.net>
Date:	Mon, 05 Mar 2012 00:05:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gaofeng@...fujitsu.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v4] ipv6: Fix problem with expired dst cache

From: Gao feng <gaofeng@...fujitsu.com>
Date: Mon, 5 Mar 2012 11:53:48 +0800

> +		/* point to where the dst_entry copied from */
> +		void			*from;

So instead of using a real type here, your just going to cast
this thing to and from "struct dst_entry *" a thousand times?

That's terrible, there is zero value from using a void pointer
here, it just makes the code look ugly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html