netdev - Re: [PATCH] ipv6: fix socket multicast check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFFC0CF6CF.38E7ECFD-ON882579B8.0066906E-882579B8.006715A9@us.ibm.com>
Date:	Mon, 5 Mar 2012 10:45:59 -0800
From:	David Stevens <dlstevens@...ibm.com>
To:	Alexandru Juncu <ajuncu@...acom.com>
Cc:	Alexandru Juncu <ajuncu@...acom.com>, alexj@...edu.org,
	davem@...emloft.net, Daniel Baluta <dbaluta@...acom.com>,
	kaber@...sh.net, kuznet@....inr.ac.ru, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ipv6: fix socket multicast check

A socket does not need to join a multicast group to receive multicast 
packets.
Group membership is per-interface. The mc lookup here is only to apply
source filters, if any, which are per-socket.

NAK.
                                                +-DLS

netdev-owner@...r.kernel.org wrote on 03/05/2012 10:12:09 AM:

> From: Alexandru Juncu <ajuncu@...acom.com>
> To: netdev@...r.kernel.org, davem@...emloft.net, yoshfuji@...ux-
> ipv6.org, kuznet@....inr.ac.ru, kaber@...sh.net
> Cc: alexj@...edu.org, Alexandru Juncu <ajuncu@...acom.com>, Daniel 
> Baluta <dbaluta@...acom.com>
> Date: 03/05/2012 10:13 AM
> Subject: [PATCH] ipv6: fix socket multicast check
> Sent by: netdev-owner@...r.kernel.org
> 
> This fixes an issue where multicast packets are delivered for
> sockets which didn't join any multicast groups.
> 
> The issue was discovered because Hello packets duplicates were
> received in OSPFv3.
> 
> Signed-off-by: Alexandru Juncu <ajuncu@...acom.com>
> Cc: Daniel Baluta <dbaluta@...acom.com>
> ---
>  net/ipv6/mcast.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index b853f06..10cc72f 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -622,7 +622,7 @@ int inet6_mc_check(struct sock *sk, const struct
> in6_addr *mc_addr,
>     }
>     if (!mc) {
>        rcu_read_unlock();
> -      return 1;
> +      return 0;
>     }
>     read_lock(&mc->sflock);
>     psl = mc->sflist;
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html