netdev - Re: [PATCH] r8169: runtime resume before shutdown.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201203062018.49348.rjw@sisk.pl>
Date:	Tue, 6 Mar 2012 20:18:49 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>,
	Sameer Nanda <snanda@...omium.org>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH] r8169: runtime resume before shutdown.

On Tuesday, March 06, 2012, Francois Romieu wrote:
> With runtime PM, if the ethernet cable is disconnected, the device is
> transitioned to D3 state to conserve energy. If the system is shutdown
> in this state, any register accesses in rtl_shutdown are dropped on
> the floor. As the device was programmed by .runtime_suspend() to wake
> on link changes, it is thus brought back up as soon as the link recovers.
> 
> Resuming every suspended device through the driver core would slow things
> down and it is not clear how many devices really need it now.
> 
> Original report and D0 transition patch by Sameer Nanda. Patch has been
> changed to comply with advices by Rafael J. Wysocki and the PM folks.
> 
> Reported-by: Sameer Nanda <snanda@...omium.org>
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Rafael J. Wysocki <rjw@...k.pl>
> Cc: Hayes Wang <hayeswang@...ltek.com>
> Cc: Alan Stern <stern@...land.harvard.edu>

Acked-by: Rafael J. Wysocki <rjw@...k.pl>

> ---
> 
>  This sucker turned my silent wake-on-alarm workstation into an early
>  sunday morning testbed takeoff. Please consider before 3.3 goes out.
> 
>  drivers/net/ethernet/realtek/r8169.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 1adf177..bbacb37 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -6194,6 +6194,9 @@ static void rtl_shutdown(struct pci_dev *pdev)
>  {
>  	struct net_device *dev = pci_get_drvdata(pdev);
>  	struct rtl8169_private *tp = netdev_priv(dev);
> +	struct device *d = &pdev->dev;
> +
> +	pm_runtime_get_sync(d);
>  
>  	rtl8169_net_suspend(dev);
>  
> @@ -6215,6 +6218,8 @@ static void rtl_shutdown(struct pci_dev *pdev)
>  		pci_wake_from_d3(pdev, true);
>  		pci_set_power_state(pdev, PCI_D3hot);
>  	}
> +
> +	pm_runtime_put_noidle(d);
>  }
>  
>  static struct pci_driver rtl8169_pci_driver = {
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html