netdev - Re: [PATCH] vlan: Support sending custom Ethernet CRC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120306.143611.152392971093262692.davem@davemloft.net>
Date:	Tue, 06 Mar 2012 14:36:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	greearb@...delatech.com, netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH] vlan: Support sending custom Ethernet CRC.

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 6 Mar 2012 16:16:34 +0000

> On Mon, 2012-03-05 at 23:12 -0500, David Miller wrote:
>> From: Ben Greear <greearb@...delatech.com>
>> Date: Mon, 05 Mar 2012 19:59:57 -0800
>> 
>> > On 03/05/2012 06:14 PM, David Miller wrote:
>> >> From: greearb@...delatech.com
>> >> Date: Mon,  5 Mar 2012 18:05:58 -0800
>> >>
>> >>> NOTE:  You will probably have to disable any
>> >>> VLAN hardware assist on the underlying device to get
>> >>> this to properly send packets with this feature enabled.
>> >>
>> >> This need to be therefore handled specifically on a device-by-device
>> >> basis, and VLAN custom CRC disabled unless the device explicitly
>> >> states that it can handle this situation properly and has any
>> >> necessary feature rule enforcement codified.
>> > 
>> > I'll see what I can come up with.  Maybe figure out how to propagate
>> > a flag up from the NIC when it is in a state that can handle VLAN +
>> > custom-CRC
>> > and only enable the flag on the VLAN in that case...
>> 
>> NETIF_F_CAN_VLAN_WITH_CUSTOM_CRC
> 
> Er... vlan_features?

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html