netdev - Re: [RFC][PATCH 0/3] TCP connection repair (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120306.161438.1544478436564514191.davem@davemloft.net>
Date:	Tue, 06 Mar 2012 16:14:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	netdev@...r.kernel.org, tj@...nel.org, eric.dumazet@...il.com
Subject: Re: [RFC][PATCH 0/3] TCP connection repair (v2)

From: Pavel Emelyanov <xemul@...allels.com>
Date: Tue, 06 Mar 2012 13:54:38 +0400

> Attempt #2 with transparent TCP connection hijacking.

This looks a lot better, the TCP_CLOSE state check makes it more clear
how this is going to be used.

Please fix up the indentation in patch #2.

+		if (!capable(CAP_SYS_ADMIN) || !(sk->sk_state == TCP_CLOSE ||
+					sk->sk_state == TCP_ESTABLISHED))

And once you sort out the details of the ->{syn,fin} bit in the fake headers
added to the repair queues you can resubmit this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html