netdev - Re: tg3: Fix to use multi queue BQL interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331013400.2474.30.camel@edumazet-laptop>
Date:	Mon, 05 Mar 2012 21:56:40 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, cl@...two.org,
	mcarlson@...adcom.com
Subject: Re: tg3: Fix to use multi queue BQL interfaces

Le lundi 05 mars 2012 à 21:53 -0800, Tom Herbert a écrit :
> Fix tg3 to use BQL multi queue related netdev interfaces since the
> device supports multi queue.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  drivers/net/ethernet/broadcom/tg3.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index bc236b6..b065746 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -5595,7 +5595,7 @@ static void tg3_tx(struct tg3_napi *tnapi)
>  		}
>  	}
>  
> -	netdev_completed_queue(tp->dev, pkts_compl, bytes_compl);
> +	netdev_tx_completed_queue(txq, pkts_compl, bytes_compl);
>  
>  	tnapi->tx_cons = sw_idx;
>  
> @@ -6971,7 +6971,7 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	}
>  
>  	skb_tx_timestamp(skb);
> -	netdev_sent_queue(tp->dev, skb->len);
> +	netdev_tx_sent_queue(txq, skb->len);
>  
>  	/* Sync BD data before updating mailbox */
>  	wmb();
> @@ -7396,8 +7396,8 @@ static void tg3_free_rings(struct tg3 *tp)
>  
>  			dev_kfree_skb_any(skb);
>  		}
> +		netdev_tx_reset_queue(netdev_get_tx_queue(tp->dev, j));
>  	}
> -	netdev_reset_queue(tp->dev);
>  }
>  
>  /* Initialize tx/rx rings for packet processing.

Reported-by: Christoph Lameter <cl@...two.org>
Acked-by: Eric Dumazet <eric.dumazet@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html