netdev - re: IPv6: Fix not join all-router mcast group when forwarding set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120307114502.GA13204@elgon.mountain>
Date:	Wed, 7 Mar 2012 14:45:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	lw@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: re: IPv6: Fix not join all-router mcast group when forwarding set.

Hello Li Wei,

This is a semi-automatic email about new static checker warnings.

The patch d6ddef9e641d: "IPv6: Fix not join all-router mcast group 
when forwarding set." from Mar 5, 2012, leads to the following Smatch 
complaint:

net/ipv6/addrconf.c:438 ipv6_add_dev()
	 warn: variable dereferenced before check 'dev' (see line 432)

net/ipv6/addrconf.c
   431		/* protected by rtnl_lock */
   432		rcu_assign_pointer(dev->ip6_ptr, ndev);
                                   ^^^^^^^^^^^^
Old dereference.

   433	
   434		/* Join all-node multicast group */
   435		ipv6_dev_mc_inc(dev, &in6addr_linklocal_allnodes);
   436	
   437		/* Join all-router multicast group if forwarding is set */
   438		if (ndev->cnf.forwarding && dev && (dev->flags & IFF_MULTICAST))
                                            ^^^

New check.  Probably you can just remove the check?

   439			ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
   440	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html