netdev - Re: [PATCH] ehea: restore multicast and rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120307141704.GA11924@oc1711230544.ibm.com>
Date:	Wed, 7 Mar 2012 11:17:04 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Anton Blanchard <anton@...ba.org>
Subject: Re: [PATCH] ehea: restore multicast and rx_errors fields

On Tue, Mar 06, 2012 at 09:46:41PM -0800, Eric Dumazet wrote:
> Commit 239c562c94d (ehea: Add 64bit statistics) added a regression,
> since we no longer report multicast & rx_errors fields, taken from
> port->stats structure. These fields are updated in ehea_update_stats()
> every second.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Anton Blanchard <anton@...ba.org>
> Cc: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/ibm/ehea/ehea_main.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 5d5fb26..e6893cd 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -336,7 +336,9 @@ static struct rtnl_link_stats64 *ehea_get_stats64(struct net_device *dev,
>  	stats->tx_bytes = tx_bytes;
>  	stats->rx_packets = rx_packets;
> 
> -	return &port->stats;
> +	stats->multicast = port->stats.multicast;
> +	stats->rx_errors = port->stats.rx_errors;
> +	return stats;
>  }
> 
>  static void ehea_update_stats(struct work_struct *work)
> 
> 

Tested, in particular, the multicast stat, pinging 224.0.0.1 from
another machine.

Thanks.
Cascardo.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Tested-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html