netdev - Re: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1331139192.15095.12.camel@br9gv9yg.de.ibm.com>
Date:	Wed, 07 Mar 2012 17:53:12 +0100
From:	Ursula Braun <ubraun@...ux.vnet.ibm.com>
To:	David.Laight@...lab.com
Cc:	Uschi IBM <ursula.braun@...ibm.com>, frank.blaschka@...ibm.com,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable

> From: "David Laight" <David.Laight@...lab.com>
> To: <frank.blaschka@...ibm.com>, <davem@...emloft.net>
> Cc: <netdev@...r.kernel.org>, <linux-s390@...r.kernel.org>,
>  <ursula.braun@...ibm.com> 
> Date: 07/03/2012 13:20
> Subject: RE: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable
> 
> What is wrong with:
>                  char addr[24];
>                  snprintf(addr, sizeof addr, "%p", rptr);
> 
> There seemed to be other 'dangerous' unbounded string
> operations in that code as well.
> 
>                  David

David,

nothing is wrong with your proposal to make use of %p here. Quite the
contrary - it improves the ctcmpc-code. I will keep your proposal in my
mind for a future follow-on ctcmpc-patch. Thanks!

My patch targets compilability of ctcmpc debugging code only.

Ursula

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html