lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <A1F3067C9B68744AA19F6802BAB8FFDC0DCD4CA3@TK5EX14MBXC227.redmond.corp.microsoft.com>
Date:	Wed, 7 Mar 2012 19:57:53 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Greg KH <greg@...ah.com>
CC:	KY Srinivasan <kys@...rosoft.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	Olaf Hering <olaf@...fle.de>
Subject: RE: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as
 driver name



> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Wednesday, March 07, 2012 2:22 PM
> To: Haiyang Zhang
> Cc: KY Srinivasan; davem@...emloft.net; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; Olaf Hering
> Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as
> driver name
> 
> On Wed, Mar 07, 2012 at 11:05:31AM -0800, Haiyang Zhang wrote:
> > From: Olaf Hering <olaf@...fle.de>
> >
> > Signed-off-by: Olaf Hering <olaf@...fle.de>
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> >  drivers/net/hyperv/netvsc_drv.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> > index 0ae7a1a..53d1ee5 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -40,6 +40,8 @@
> >
> >  #include "hyperv_net.h"
> >
> > +#define MODULE_NAME "hv_netvsc"
> 
> No, please use the built-in macro for this and don't define your own,
> that's totally redundant.

I have submitted a patch using the built-in KBUILD_MODNAME.
Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ