netdev - [PATCH] iwlwifi: Add _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1331151811.2140.75.camel@joe2Laptop>
Date:	Wed, 07 Mar 2012 12:23:31 -0800
From:	Joe Perches <joe@...ches.com>
To:	Wey-Yi Guy <wey-yi.w.guy@...el.com>
Cc:	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	Intel Linux Wireless <ilw@...ux.intel.com>
Subject: [PATCH] iwlwifi: Add __printf verification

Make sure that arguments match formats.
All current uses do.

Signed-off-by: Joe Perches <joe@...ches.com>
---
 drivers/net/wireless/iwlwifi/iwl-debug.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index 01b2330..42e6bbb 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -34,10 +34,14 @@
 
 struct iwl_priv;
 
+__printf(4, 5)
 void __iwl_err(struct device *dev, bool rfkill_prefix, bool only_trace,
 		const char *fmt, ...);
+__printf(2, 3)
 void __iwl_warn(struct device *dev, const char *fmt, ...);
+__printf(2, 3)
 void __iwl_info(struct device *dev, const char *fmt, ...);
+__printf(2, 3)
 void __iwl_crit(struct device *dev, const char *fmt, ...);
 
 /* No matter what is m (priv, bus, trans), this will work */
@@ -47,10 +51,12 @@ void __iwl_crit(struct device *dev, const char *fmt, ...);
 #define IWL_CRIT(m, f, a...) __iwl_crit(trans(m)->dev, f, ## a)
 
 #if defined(CONFIG_IWLWIFI_DEBUG) || defined(CONFIG_IWLWIFI_DEVICE_TRACING)
+__printf(6, 7)
 void __iwl_dbg(struct iwl_shared *shared, struct device *dev,
 	       u32 level, bool limit, const char *function,
 	       const char *fmt, ...);
 #else
+__printf(6, 7)
 static inline void
 __iwl_dbg(struct iwl_shared *shared, struct device *dev,
 	  u32 level, bool limit, const char *function,


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html