netdev - Re: [PATCH] dlm, sctp: Do not allocate a fd for peeloff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120308.002447.1062706659978103072.davem@davemloft.net>
Date:	Thu, 08 Mar 2012 00:24:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vladislav.yasevich@...com
Cc:	bpoirier@...e.de, ccaulfie@...hat.com, teigland@...hat.com,
	sri@...ibm.com, cluster-devel@...hat.com,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dlm, sctp: Do not allocate a fd for peeloff

From: Vladislav Yasevich <vladislav.yasevich@...com>
Date: Wed, 07 Mar 2012 11:29:20 -0500

> On 03/07/2012 10:41 AM, Benjamin Poirier wrote:
>> avoids allocating a fd that a) propagates to every kernel thread and
>> usermodehelper b) is not properly released.
>> 
>> References: http://article.gmane.org/gmane.linux.network.drbd/22529
>> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
> 
> It might make sense to change sctp_do_peeloff to take the association id as
> the first argument and not do the mapping from id to association yourself.
> It's a bit ugly to expose internal sctp structures outside of SCTP.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html