netdev - Re: [PATCH] iproute: fix tc -iec display of Mibit rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 10 Mar 2012 09:14:25 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	netdev@...r.kernel.org,
	Thomas Mühlgrabner <muehltom@...le.vol.at>
Subject: Re: [PATCH] iproute: fix tc -iec display of Mibit rates

On Fri, 9 Mar 2012 17:09:19 +0100
Andreas Henriksson <andreas@...al.se> wrote:

> As reported by Thomas Mühlgrabner <muehltom@...le.vol.at>
> in http://bugs.debian.org/662979 :
> 
>  When showing htb class configuration with "tc -iec class show",
>  the output for Mibit is actually the value for bit.
>  Example: configure a class with a ceil of 1000Mibit.
>  Output states 1048576000 Mibit.
> 
> The cause is missing parenteses in the display code of tc....
> 
> (Please also note that a lower value of 100Mibit will be displayed
> as 102400 Kibit, which I think is kind of ugly.)
> 
> Reported-by: Thomas Mühlgrabner <muehltom@...le.vol.at>
> Signed-off-by: Andreas Henriksson <andreas@...al.se>
> 
> diff --git a/tc/tc_util.c b/tc/tc_util.c
> index 5829d61..36e3c7d 100644
> --- a/tc/tc_util.c
> +++ b/tc/tc_util.c
> @@ -203,7 +203,7 @@ void print_rate(char *buf, int len, __u32 rate)
>  
>  	if (use_iec) {
>  		if (tmp >= 1000.0*1024.0*1024.0)
> -			snprintf(buf, len, "%.0fMibit", tmp/1024.0*1024.0);
> +			snprintf(buf, len, "%.0fMibit", tmp/(1024.0*1024.0));
>  		else if (tmp >= 1000.0*1024)
>  			snprintf(buf, len, "%.0fKibit", tmp/1024);
>  		else

Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html