lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120311.154219.270150852508281564.davem@davemloft.net> Date: Sun, 11 Mar 2012 15:42:19 -0700 (PDT) From: David Miller <davem@...emloft.net> To: julia.lawall@...6.fr Cc: chas@....nrl.navy.mil, kernel-janitors@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible From: Julia Lawall <julia.lawall@...6.fr> Date: Sun, 11 Mar 2012 22:16:25 +0100 (CET) > From: Julia Lawall <Julia.Lawall@...6.fr> > > Convert calls to free_irq so that the second argument is the same as > the > last argument of the corresponding call to request_irq. Without this > property, free_irq does nothing. > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> Applied, but this driver also has a larger problem, it doesn't free the IRQ (nor do any other kind of chip shutdown and cleanups) when the driver is unloaded. The unload function is just one empty function with a comment. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists