lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6E9D@saturn3.aculab.com> Date: Mon, 12 Mar 2012 13:16:43 -0000 From: "David Laight" <David.Laight@...LAB.COM> To: "Marek Lindner" <lindner_marek@...oo.de>, <davem@...emloft.net> Cc: <netdev@...r.kernel.org>, <b.a.t.m.a.n@...ts.open-mesh.org>, "Sven Eckelmann" <sven@...fation.org> Subject: RE: [PATCH 3/4] batman-adv: Use {} braces consistent on the arms of a statement > diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c > index 01b66d4..7f8e158 100644 > --- a/net/batman-adv/routing.c > +++ b/net/batman-adv/routing.c > @@ -237,8 +237,9 @@ int window_protected(struct bat_priv > *bat_priv, int32_t seq_num_diff, > "old packet received, start protection\n"); > > return 0; > - } else > + } else { > return 1; > + } > } > return 0; > } Doesn't this one fail on the "don't use 'else' after return/break" ? Also look like it would read better if the condition (not quoted) were inverted and the 'return 1' put first. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists