netdev - Re: [PATCH] stmmac: Add device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2012 16:14:37 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Stefan Roese <sr@...x.de>
Cc:	Rob Herring <robherring2@...il.com>, netdev@...r.kernel.org,
	Viresh Kumar <viresh.kumar@...com>,
	devicetree-discuss@...abs.org,
	linux-arm-kernel@...ts.infradead.org,
	Giuseppe Cavallaro <peppe.cavallaro@...com>
Subject: Re: [PATCH] stmmac: Add device-tree support

On 16:06 Mon 12 Mar     , Stefan Roese wrote:
> Hi Rob,
> 
> On Monday 12 March 2012 15:34:59 Rob Herring wrote:
> > On 03/12/2012 09:05 AM, Stefan Roese wrote:
> > > This patch adds support to configure the STMMAC ethernet driver via
> > > device-tree instead of platform_data.
> > > 
> > > Currently, only the properties needed on SPEAr600 are provided. All
> > > other properties should be added once needed on other platforms.
> > > 
> > > Signed-off-by: Stefan Roese <sr@...x.de>
> > > Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> > > Cc: Viresh Kumar <viresh.kumar@...com>
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/net/stmmac.txt   |   38 +++++++++++
> > >  .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   66
> > >  +++++++++++++++++++- 2 files changed, 103 insertions(+), 1 deletion(-)
> > >  create mode 100644 Documentation/devicetree/bindings/net/stmmac.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt
> > > b/Documentation/devicetree/bindings/net/stmmac.txt new file mode 100644
> > > index 0000000..386a47f
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> > > @@ -0,0 +1,38 @@
> > > +* STMicroelectronics 10/100/1000 Ethernet driver (GMAC)
> > > +
> > > +Required properties:
> > > +- compatible: Should be "stm,gmac"
> > 
> > This is too generic. This should be 1 string per version of h/w.
> 
> Viresh, Giuseppe, can you please suggest a proper string for the SPEAr600 
> STMMAC core, including version?
IIRC this IP is the same as the sti7108

st,sti7018-gmac

as this IP has been used first on SH4

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html