netdev - Re: [PATCH] stmmac: Add device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2012 16:17:02 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Stefan Roese <sr@...x.de>
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree-discuss@...abs.org,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Viresh Kumar <viresh.kumar@...com>
Subject: Re: [PATCH] stmmac: Add device-tree support

On 16:25 Mon 12 Mar     , Stefan Roese wrote:
> On Monday 12 March 2012 15:38:25 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > @@ -58,6 +94,22 @@ static int stmmac_pltfr_probe(struct platform_device
> > > *pdev)
> > > 
> > >  		ret = -ENOMEM;
> > >  		goto out_release_region;
> > >  	
> > >  	}
> > > 
> > > +
> > > +#ifdef CONFIG_OF
> > > +	plat_dat = devm_kzalloc(&pdev->dev, sizeof(struct
> > > plat_stmmacenet_data), +				GFP_KERNEL);
> > > +	if (!plat_dat) {
> > > +		pr_err("%s: ERROR: no memory", __func__);
> > > +		ret = -ENOMEM;
> > > +		goto out_unmap;
> > > +	}
> > > +
> > > +	ret = stmmac_probe_config_dt(pdev, plat_dat, &mac);
> > > +	if (ret) {
> > > +		pr_err("%s: main dt probe failed", __func__);
> > > +		goto out_unmap;
> > > +	}
> > > +#else
> > 
> > This must be check at runtime, we can boot a kernel with or without DT.
> 
> Are you referring to using "if (pdev->dev.of_node)" to distinguish between DT 
> and non-DT version instead of this #ifdef?
yes

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html