netdev - Re: VLAN regression caused by: e1000: do vlan cleanup (799d531).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 11:44:18 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Jiri Pirko <jpirko@...hat.com>
CC:	e1000-devel list <e1000-devel@...ts.sourceforge.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: VLAN regression caused by: e1000: do vlan cleanup (799d531).

On 03/13/2012 02:59 AM, Jiri Pirko wrote:
> Mon, Mar 12, 2012 at 07:17:51PM CET, greearb@...delatech.com wrote:
>> This commit breaks 802.1Q VLANs on my e1000 NIC, and it remains broken in top-of-tree
>> (as of 2 days ago, at least).
>>
>> commit 5622e4044a916de1af84bfcc4d437ce0c799d531
>> Author: Jiri Pirko<jpirko@...hat.com>
>> Date:   Thu Jul 21 03:26:31 2011 +0000
>>
>>     e1000: do vlan cleanup
>>
>>     - unify vlan and nonvlan rx path
>>     - kill adapter->vlgrp and e1000_vlan_rx_register
>>     - allow to turn on/off rx/tx vlan accel via ethtool (set_features)
>>
>>     Signed-off-by: Jiri Pirko<jpirko@...hat.com>
>>     Signed-off-by: David S. Miller<davem@...emloft.net>
>>
>>
>> My OS is RH 8, 32-bit.
>>
>> My e1000 hardware is:
>>
>> 05:01.0 Ethernet controller: Intel Corporation 82546GB Gigabit Ethernet Controller (rev 03)
>> 	Subsystem: Intel Corporation PRO/1000 MT Dual Port Server Adapter
>> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx-
>> 	Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium>TAbort-<TAbort-<MAbort->SERR-<PERR- INTx-
>> 	Latency: 52 (63750ns min), Cache Line Size: 32 bytes
>> 	Interrupt: pin A routed to IRQ 24
>> 	Region 0: Memory at d8100000 (64-bit, non-prefetchable) [size=128K]
>> 	Region 4: I/O ports at 3000 [size=64]
>> 	Capabilities: [dc] Power Management version 2
>> 		Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
>> 		Status: D0 PME-Enable- DSel=0 DScale=1 PME-
>> 	Capabilities: [e4] PCI-X non-bridge device
>> 		Command: DPERE- ERO+ RBC=512 OST=1
>> 		Status: Dev=05:01.0 64bit+ 133MHz+ SCD- USC- DC=simple DMMRBC=2048 DMOST=1 DMCRS=16 RSCEM- 266MHz- 533MHz-
>> 	Capabilities: [f0] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
>> 		Address: 0000000000000000  Data: 0000
>> 	Kernel driver in use: e1000
>> 	Kernel modules: e1000
>>
>> 05:01.1 Ethernet controller: Intel Corporation 82546GB Gigabit Ethernet Controller (rev 03)
>> 	Subsystem: Intel Corporation PRO/1000 MT Dual Port Server Adapter
>> 	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx-
>> 	Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium>TAbort-<TAbort-<MAbort->SERR-<PERR- INTx-
>> 	Latency: 52 (63750ns min), Cache Line Size: 32 bytes
>> 	Interrupt: pin B routed to IRQ 25
>> 	Region 0: Memory at d8120000 (64-bit, non-prefetchable) [size=128K]
>> 	Region 4: I/O ports at 3040 [size=64]
>> 	Capabilities: [dc] Power Management version 2
>> 		Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
>> 		Status: D0 PME-Enable- DSel=0 DScale=1 PME-
>> 	Capabilities: [e4] PCI-X non-bridge device
>> 		Command: DPERE- ERO+ RBC=512 OST=1
>> 		Status: Dev=05:01.1 64bit+ 133MHz+ SCD- USC- DC=simple DMMRBC=2048 DMOST=1 DMCRS=16 RSCEM- 266MHz- 533MHz-
>> 	Capabilities: [f0] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
>> 		Address: 0000000000000000  Data: 0000
>> 	Kernel driver in use: e1000
>> 	Kernel modules: e1000
>>
>>
>> I'm attaching ethregs output from good and bad kernels, in case that helps.
>>
>> The symptom is that pkts show up as 'ISL' instead of Ethernet frames.  I'm
>> including a capture of that as well.  I am sending UDP pkts from one NIC to the other,
>> on vlan 8, though because ARP fails, no UDP is ever sent.  The sniff shows rcvd pkts
>> as looking funky, but it could be they are transmitted badly once they hit the NIC,
>> so I don't know if it's actually rx or tx (or both) logic that is busted at this point.
>>
>> I'm using routing rules to make send-to-self work, but the kernel is un-patched.
>>
>> Please let me know if you need additional info.  I'll be happy to test patches,
>> I have a good setup to reproduce this easily.
>
> Thanks for the report Ben.
>
> It would help it you try to enable/disable vlan hw accel by ethtool to
> see if it helps.
>
> I have suspition that vlan filter must be on/offed along with vlan
> accel.

Ok, if I disable rx-vlan-hw-parse on both NICs, traffic starts working.

And, if I re-enable rx-vlan-hw-parse on both NICs, it continues to work.

Maybe the initialization logic needs some fixing?

This is on 3.3.0-rc7+.

Thanks,
Ben


-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html