netdev - RE: [net 2/2] net: fix a bug of dropping FCoE frames when disabling tx ip checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <138EA028228D124A900F5E6746F3C2160F6B5377@ORSMSX102.amr.corp.intel.com>
Date:	Wed, 14 Mar 2012 22:04:06 +0000
From:	"Zou, Yi" <yi.zou@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net 2/2] net: fix a bug of dropping FCoE frames when disabling
 tx ip checksum

> 
> From: "Zou, Yi" <yi.zou@...el.com>
> Date: Wed, 14 Mar 2012 20:48:03 +0000
> 
> > CHECKSUM_UNNECESSARY sounds good to me, if it's ok to be used on the tx
> path 
> > as well, I think so but I am not 100% sure, it'd resolve this for fcoe
> and sctp
> > like, downside is it's a bigger change that requires corresponding
> changes in
> > these protocol driver stacks as well.
> 
> This is definitely the way this bug should be fixed, CHECKSUM_PARTIAL should
> never be set for packets outside of the domain that value was designed for.

Cool, then please drop this patch and I will fix this by changing the fcoe 
protocol stack driver to use CHECKSUM_UNNECESSARY instead.

yi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html