netdev - Re: [net 2/2] net: fix a bug of dropping FCoE frames when disabling tx ip checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120314082529.584a669f@nehalam.linuxnetplumber.net>
Date:	Wed, 14 Mar 2012 08:25:29 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Yi Zou <yi.zou@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 2/2] net: fix a bug of dropping FCoE frames when disabling
 tx ip checksum

On Wed, 14 Mar 2012 00:01:58 -0700
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> From: Yi Zou <yi.zou@...el.com>
> 
> Fix a bug when using 'ethtool -K ethx tx off' to turn off tx ip checksum,
> FCoE CRC offload should not be impacte. The skb_checksum_help() is needed
> only if it's not FCoE traffic for ip checksum, regardless of ethtool toggling
> the tx ip checksum on or off.
> 
> Signed-off-by: Yi Zou <yi.zou@...el.com>
> Tested-by: Ross Brattain <ross.b.brattain@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  net/core/dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 6ca32f6..9e378009 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1913,6 +1913,9 @@ int skb_checksum_help(struct sk_buff *skb)
>  	__wsum csum;
>  	int ret = 0, offset;
>  
> +	if (skb->protocol == htons(ETH_P_FCOE))
> +		goto out;
> +
>  	if (skb->ip_summed == CHECKSUM_COMPLETE)
>  		goto out_set_summed;
>  

Shouldn't this be done in the offending driver rather than the core?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html