netdev - RE: [PATCH] net/hyperv: fix erroneous NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331756072.6022.57.camel@edumazet-glaptop>
Date:	Wed, 14 Mar 2012 13:14:32 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Haiyang Zhang <haiyangz@...rosoft.com>
Cc:	Ben Greear <greearb@...delatech.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	KY Srinivasan <kys@...rosoft.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: RE: [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use

On Wed, 2012-03-14 at 20:00 +0000, Haiyang Zhang wrote:

> Actually, I'm working on this bug, and have a patch under our internal 
> review now. My fix is actually not freeing the SKB, and return NETDEV_TX_BUSY.
> 
> Even if the vmbus ring buffer is busy currently, it can be available during
> the next re-try, because the host is taking away data from ring buffer. The 
> stop/wake queue mechanism is in the netvsc.c file.
> 
> In the out-of-memory case, dropping packet and return NETDEV_TX_OK seems fine.

That will be fine for net-next.

I sent a patch for current kernels, where obvious and minimal fixes
apply.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html