netdev - iproute2: iplink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGm1_kuHYCRuoUEfBeV6GbjypUJgr1_058f-e4AhojHP1fTJWg@mail.gmail.com>
Date:	Thu, 15 Mar 2012 14:53:51 +0100
From:	Yegor Yefremov <yegorslists@...glemail.com>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: iproute2: iplink_ stuff cleanup

Hello Stephen,

I'm still struggling to get ip/iplink_* routines to show up in
Android's ip binary
(https://groups.google.com/d/topic/android-building/yjV4iYnT1Zc/discussion).
I've looked at the algorithm that is used to access those functions
(like can_parse_opt, vlan_parse_opt etc.)

 snprintf(buf, sizeof(buf), LIBDIR "/ip/link_%s.so", id);
        dlh = dlopen(buf, RTLD_LAZY);
        if (dlh == NULL) {
                /* look in current binary, only open once */
                dlh = BODY;
                if (dlh == NULL) {
                        dlh = BODY = dlopen(NULL, RTLD_LAZY);
                        if (dlh == NULL)
                                return NULL;
                }
        }

        snprintf(buf, sizeof(buf), "%s_link_util", id);
        l = dlsym(dlh, buf);
        if (l == NULL)
                return NULL;

as far as I can see from the ip/Makefile there are no dynamic libs
like /ip/link_%s.so. Wouldn't it be simpler to let all iplink_*
objects to export their interfaces via header files and just make a
table in ip/iplink.c to hold protocol ID and pointer at link_utils
struct.

struct link_util can_link_util = {
        .id             = "can",
        .maxattr        = IFLA_CAN_MAX,
        .parse_opt      = can_parse_opt,
        .print_opt      = can_print_opt,
        .print_xstats   = can_print_xstats,
};

Am I missing something?

Regards,
Yegor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html