lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Mar 2012 15:37:42 -0700 From: Anirban Chakraborty <anirban.chakraborty@...gic.com> To: Ben Hutchings <bhutchings@...arflare.com>, Eric Dumazet <eric.dumazet@...il.com> CC: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Dept-NX Linux NIC Driver <Dept_NX_Linux_NIC_Driver@...gic.com>, Manish Chopra <manish.chopra@...gic.com> Subject: Re: [PATCH net-next] ethtool: Added a field fw dump_state On 3/16/12 2:37 PM, "Ben Hutchings" <bhutchings@...arflare.com> wrote: >On Fri, 2012-03-16 at 14:22 -0700, Eric Dumazet wrote: >> On Fri, 2012-03-16 at 14:10 -0700, Anirban Chakraborty wrote: >> > >> > On 3/16/12 11:27 AM, "Ben Hutchings" <bhutchings@...arflare.com> >>wrote: >> > >> > >On Fri, 2012-03-16 at 10:58 -0700, Anirban Chakraborty wrote: >> > >> + >> > >> struct ethtool_dump { >> > >> __u32 cmd; >> > >> __u32 version; >> > >> __u32 flag; >> > >> __u32 len; >> > >> __u8 data[0]; >> > >> + __u8 dump_state; >> > > >> > >Don't be ridiculous. >> > >> > Yeah I know, especially when there is a flag field already present >>there. >> > The only >> > reason, we considered for adding it is to keep the backward >>compatibility >> > of scripts. >> > Right now, the flag field sets/gets the dump level of fw. If we use >>it to >> > control the >> > dump state, then it would break the existing scripts, if there are >>any. >> > >> >> You missed the point... data[0] must be the last element in the >> structure. > >Right. And len is documented as not used by the ETHTOOL_SET_DUMP >command so we cannot say that when len == 1 then data[0] is this new >flag. > >Just reserve some value of the flag to mean 'disable', say 0 or >0xffffffff. If you want this 'disable' value to be understood by all >drivers and have ethtool support a keyword for it then also define a >macro for the value in ethtool.h. Thanks for your comments. We'll take care of it next submittal. -Anirban -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists