netdev - RE: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 10:21:40 +0000
From:	"N, Mugunthan V" <mugunthanvnm@...com>
To:	Peter Korsgaard <jacmet@...site.dk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

Peter

> -----Original Message-----
> From: Peter Korsgaard [mailto:jacmet@...il.com] On Behalf Of Peter
> Korsgaard
> Sent: Thursday, March 01, 2012 7:10 PM
> To: N, Mugunthan V
> Cc: netdev@...r.kernel.org; davem@...emloft.net
> Subject: Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver
> 
> >>>>> "N" == N, Mugunthan V <mugunthanvnm@...com> writes:
> 
> Hi,
> 
>  >> Is this really platform specific data (rather than SoC specific)? If
>  >> it's purely a difference between 335x and 814x just use an id_table
> with
>  >> different platform device names instead.
> 
>  N> Instead of driver maintaining the SoC specific offsets, SoC specific
>  N> files in arch/arm/mach-omap2/ can hold this. Another reason is
>  N> currently this IP is present in 2 SoCs, there are other SoC coming
>  N> up where the offsets may change.
> 
> Sure, it's the same amount of code no matter where it gets put, but the
> idea is to move code from arch/arm to drivers/ where possible. This will
> also help if the IP is ever used on non-omap2 platforms and for device
> tree support.

Instead of keeping the SoC Specific data in driver keeping it in hwmod will
be fine and while supporting Device tree, driver will receive the same data
from device tree, so I will keep the offsets in hwmod itself.

> 
> --
> Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html