netdev - Re: [PATCH] ipv6: Don't dev_hold(dev) in ip6_mc_find_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120316.215724.388331662024242970.davem@davemloft.net>
Date:	Fri, 16 Mar 2012 21:57:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	roy.qing.li@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Don't dev_hold(dev) in ip6_mc_find_dev_rcu.

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 16 Mar 2012 07:15:53 -0700

> Le vendredi 16 mars 2012 à 16:54 +0800, roy.qing.li@...il.com a écrit :
>> From: RongQing.Li <roy.qing.li@...il.com>
>> 
>> ip6_mc_find_dev_rcu() is called with rcu_read_lock(), so don't
>> need to dev_hold().
>> With dev_hold(), not corresponding dev_put(), will lead to leak.
>> 
>> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>
 ...
> Nice catch, bug introduced in 96b52e61be1 (ipv6: mcast: RCU conversions)
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html