netdev - Re: [PATCH net-next 33/34] dmfe: stop using net_device.{base_addr, irq} and convert to _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120317113147.GB20532@electric-eye.fr.zoreil.com>
Date:	Sat, 17 Mar 2012 12:31:47 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Grant Grundler <grantgrundler@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH net-next 33/34] dmfe: stop using net_device.{base_addr, irq} and convert to __iomem.

Grant Grundler <grantgrundler@...il.com> :
[...]
> is there any reason you didn't want to directly use iowrite/ioread routines?

I wanted to keep this patch small and easy to review. David suggested doing
the right thing from the start. I'll send an updated version.

> There is a semantic difference between outl and iowrite. Having
> "outl()" source but instead generate an MMIO transaction could lead to
> misunderstanding/bugs about posted MMIO writes. So I'd rather see a
> direct transition to iowrite and just ditch all the inb/outb stuff.

Ok.

> I'm still suffering from jetlag right now and am not able to review
> the rest of the patch now. I'll try to take a look at it tomorrow.

Thanks. No need to hurry until I send an update though.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html