netdev - Re: [PATCH net-next v3] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332002201.19406.25.camel@edumazet-glaptop>
Date:	Sat, 17 Mar 2012 09:36:41 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nick Jones <nick.jones@...work-box.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] ipv6: Allocate unique metrics for icmp6
 packets to prevent tainting dst metrics

On Sat, 2012-03-17 at 23:47 +0800, Nick Jones wrote:
> The generation of an icmp6 packet, targeted to a specific desination
> address, will cause the shared metrics of the ip6_dst and inetpeer
> of that address to be tainted with the hoplimit value 255.
> All packets, icmp6 or otherwise, will have this hoplimit value, and
> if the destination is a router, not even advertisements specifying a
> new hoplimit value will have any effect due to the way
> ip6_dst_hoplimit works.
> 
> By allocating a unique metrics array for the icmp6 packet, the shared
> metrics will not be tainted.  A ip6_dst flag is added to indicate that
> the metrics for the dst don't belong to the peer, thus are not unique
> and should be freed when the dst is freed.
> 
> Signed-off-by: Nick Jones <nick.jones@...work-box.com>
> ---

> +	}
> +	dst_init_metrics(&rt->dst, metrics, 0);

Dont be fooled by 8e2ec639 precedent, third argument is a bool, so
please use 'false' instead of 0



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html