netdev - Re: [PATCH net-next] usbnet: use netif_tx_wake_queue instead of netif_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120316.225049.279188750788151013.davem@davemloft.net>
Date:	Fri, 16 Mar 2012 22:50:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oneukum@...e.de
Cc:	alexey.orishko@...il.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, greg@...ah.com,
	alexey.orishko@...ricsson.com
Subject: Re: [PATCH net-next] usbnet: use netif_tx_wake_queue instead of
 netif_start_queue

From: Oliver Neukum <oneukum@...e.de>
Date: Thu, 15 Mar 2012 18:05:09 +0100

> Am Mittwoch, 14. März 2012, 15:00:24 schrieb Alexey Orishko:
>> If host is going to autosuspend function with two interfaces and
>> if IP packet has arrived in-between of two usbnet_suspend() callbacks,
>> i.e usbnet_resume() is called in-between, tx data flow is stopped.
>> When autosuspend timer expires and device is put to autosuspend
>> again, tx queue is waked up and data can be sent again.
>> This behavior might be repeated several times in a row.
>> 
>> Tested on Intel/ARM.
>> 
>> Reviewed-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>
>> Tested-by: Dmitry Tarnyagin <dmitry.tarnyagin@...ricsson.com>
>> Signed-off-by: Alexey Orishko <alexey.orishko@...ricsson.com>
> Acked-by: Oliver Neukum <oneukum@...e.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html