netdev - Re: [net 3/3] fcoe: use CHECKSUM_UNNECESSARY instead of CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120319.173820.1719327813128013795.davem@davemloft.net>
Date:	Mon, 19 Mar 2012 17:38:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	yi.zou@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, JBottomley@...allels.com,
	robert.w.love@...el.com
Subject: Re: [net 3/3] fcoe: use CHECKSUM_UNNECESSARY instead of
 CHECKSUM_PARTIAL on tx

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 17 Mar 2012 02:08:12 -0700

> From: Yi Zou <yi.zou@...el.com>
> 
> Fix a bug when using 'ethtool -K ethx tx off' to turn off tx ip checksum,
> FCoE CRC offload should not be impacte. The skb_checksum_help() is needed
> only if it's not FCoE traffic for ip checksum, regardless of ethtool toggling
> the tx ip checksum on or off. Instead of using CHECKSUM_PARTIAL, we will
> use CHECKSUM_UNNECESSARY as a proper indication to avoid sw ip checksum
> on FCoE frames.
> 
> Ref. to original discussion thread:
> http://patchwork.ozlabs.org/patch/146567/
> 
> CC: "James E.J. Bottomley" <JBottomley@...allels.com>
> CC: Robert Love <robert.w.love@...el.com>
> Signed-off-by: Yi Zou <yi.zou@...el.com>
> Tested-by: Ross Brattain <ross.b.brattain@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html