netdev - Re: [PATCH] adjust __net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Mar 2012 09:09:49 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Sam Ravnborg" <sam@...nborg.org>
Cc:	"David Miller" <davem@...emloft.net>, <xemul@...nvz.org>,
	<netdev@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
	<ebiederm@...ssion.com>
Subject: Re: [PATCH] adjust __net_exit

>>> On 19.03.12 at 09:47, Sam Ravnborg <sam@...nborg.org> wrote:
>> >> > Using the (bogus and unused elsewhere)
>> >> > __exit_refok to implement this is inefficient - any non-modular code
>> >> > really can reside in __init (as non-modular __exit code is never used).
> 
>> > 2) fix up the bogus commit message
>> 
>> Bogus in what way?
> 
> I fail to see that __exit_refok is bogus.

Either an exit function references only permitted code (in which case
it is legitimately using __exit), or it references non-__exit code, in
which case it shouldn't have an override at all. Permitting an exit
function to reference e.g. __init code is suspicious (at best) in all
cases I can think of (in contrast to allowing a non-init function to
reference __init code on a code path that can be proven to be taken
only during system startup).

Jan

> The name is not optimal - which is why is is deprecated.
> 
> 	Sam

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html