netdev - RE: [net 2/3] net: do not do gso for CHECKSUM_UNNECESSARY in netif_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <138EA028228D124A900F5E6746F3C2160F6BAF24@ORSMSX102.amr.corp.intel.com>
Date:	Mon, 19 Mar 2012 15:11:07 +0000
From:	"Zou, Yi" <yi.zou@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net 2/3] net: do not do gso for CHECKSUM_UNNECESSARY in
 netif_needs_gso

> 
> On Sat, 2012-03-17 at 02:08 -0700, Jeff Kirsher wrote:
> > From: Yi Zou <yi.zou@...el.com>
> >
> > This is related to fixing the bug of dropping FCoE frames when
> disabling tx ip
> > checksum by 'ethtool -K ethx tx off'. The FCoE protocol stack driver
> would
> > use CHECKSUM_UNNECESSARY on tx path instead of CHECKSUM_PARTIAL (as
> indicated in
> > the 2/2 of this series). To do so, netif_needs_gso() has to be changed
> here to
> > not do gso for both CHECKSUM_PARTIAL and CHECKSUM_UNNECESSARY.
> [...]
> 
> This should also be documented as valid in include/linux/skbuff.h,
> though I don't think the fix should be held up for that.
> 
> Ben.
Sure, I will send a separate patch to update the skbuff.h shortly.

Thanks,
yi

> 
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.