lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1332216396.22737.29.camel@edumazet-glaptop> Date: Mon, 19 Mar 2012 21:06:36 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...emloft.net> Cc: mugunthanvnm@...com, netdev@...r.kernel.org Subject: Re: [PATCH v5 0/2] Adding new TI Common Platform ethernet SWitch driver On Mon, 2012-03-19 at 18:06 -0400, David Miller wrote: > From: Mugunthan V N <mugunthanvnm@...com> > Date: Mon, 19 Mar 2012 11:47:52 +0530 > > > The following series contains driver implementation for TI Common Platform > > ethernet SWitch (CPSW) driver. > > > > CPSW is found in following SoC. > > * AM335X - http://www.ti.com/litv/pdf/spruh73c > > * DM814X - http://www.ti.com/litv/pdf/sprugz8 > > > > CPSW: > > The three port switch gigabit ethernet subsystem provides ethernet packet > > communication and can be configured as an ethernet switch. It > > supports 10/100/1000 Mbps. It provides the gigabit media independent > > interface (G/MII), reduced gigabit media independent interface (RGMII), > > reduced media independent interface (RMII), the management data input > > output (MDIO) for physical layer device (PHY) management. > > All applied. It appears this driver doesnt have a ndo_change_mtu method, so I suspect some bad things could happen. I wonder if we should WARN is netdev_ops->ndo_change_mtu is NULL For an ethernet driver, using eth_change_mtu seems the right thing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists