lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4F67D8AE.2070602@cn.fujitsu.com> Date: Tue, 20 Mar 2012 09:09:02 +0800 From: Gao feng <gaofeng@...fujitsu.com> To: Steffen Klassert <steffen.klassert@...unet.com> CC: davem@...emloft.net, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment 于 2012年03月19日 16:02, Steffen Klassert 写道: > On Fri, Mar 16, 2012 at 04:57:15PM +0800, Gao feng wrote: >> Since commit 299b0767(ipv6: Fix IPsec slowpath fragmentation problem) >> In func ip6_append_data,after call skb_put(skb, fraglen + dst_exthdrlen) >> the skb->len contains dst_exthdrlen,and we don't reduce dst_exthdrlen at last >> This will make fraggap>0 in next "while cycle",and cause the size of skb incorrent > > Good catch! > >> >> Call skb_pull reduce skb->len before next "while cycle" > > I think it would be better to just reserve headroom for > dst_exthdrlen instead of adding and removing data to/from > the skb. > Hi steffen & David: Thanks for your comment. Agree with you,I will send v2 patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists