netdev - Re: netlink: 12 bytes leftover after parsing attributes - triggered by iproute2 libnetlink's rtnl_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120320080917.77765344@nehalam.linuxnetplumber.net>
Date:	Tue, 20 Mar 2012 08:09:17 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	netdev@...r.kernel.org, Greg Rose <gregory.v.rose@...el.com>
Subject: Re: netlink: 12 bytes leftover after parsing attributes - triggered
 by iproute2 libnetlink's rtnl_dump_request()

On Tue, 20 Mar 2012 16:00:23 +0100
Bruno Prémont <bonbons@...ux-vserver.org> wrote:

> On Tue, 20 Mar 2012 07:41:40 Stephen Hemminger wrote:
> > > Should this get fixed at kernel level, iproute2 libnetlink level or
> > > at end-user level (e.g. collectd)?
> > > Three lines every 10 seconds is a damn lot!
> > > 
> > > Thanks,
> > > Bruno
> > 
> > Netlink is supposed to be encoded as Type-Length-Value and correctly written
> > programs ignore types they don't understand. So either the library is getting
> > confused by the type or the attribute is not encoded correctly.
> > 
> > 
> > The issue could be in libnetlink library. What version of collectd and libnetlink
> > are you using?
> 
> I've used collectd-5.0.x and collectd-4.10.3 with 3.3 kernels.
> The stub code I listed is what collectd's netlink plugin does with
> libnetlink (processing of netlink reply factored out for short-ness)
> 
> In all cases, linked against libnetlink from iproute2-2.6.38 (on
> Gentoo)
> 
> 
> From looking at git history of both collectd and iproute2, on both
> sides there has not been any changes that would affect the result.
> 
> Collectd:
>   http://git.verplant.org/?p=collectd.git;a=history;f=src/netlink.c;hb=HEAD

It is most likely in the libnetlink code, I'll look there.  Since libnetlink
is not really an exported API, I wish applications would use a real
library like libmnl instead rather than copying it out of iproute2.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html