netdev - Re: [PATCH v3 4/4] ath9k: Support ethtool getstats api.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F68B4AA.3070306@candelatech.com>
Date:	Tue, 20 Mar 2012 09:47:38 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 4/4] ath9k:  Support ethtool getstats api.

On 03/20/2012 01:42 AM, Florian Fainelli wrote:
> Hi,
>
> Le 03/19/12 19:51, greearb@...delatech.com a écrit :
>> From: Ben Greear<greearb@...delatech.com>
>>
>> This returns many of the values that formerly could
>> only be obtained from debugfs. This should be an
>> improvement when trying to access these counters
>> programatically. Currently this support is only
>> enabled when DEBUGFS is enabled because otherwise
>> these stats are not accumulated.
>>
>> Signed-off-by: Ben Greear<greearb@...delatech.com>
>> ---
>>
>> v3: No changes from v2
>>
>> :100644 100644 4a00806... 7261f88... M drivers/net/wireless/ath/ath9k/main.c
>> drivers/net/wireless/ath/ath9k/main.c | 134 +++++++++++++++++++++++++++++++++
>> 1 files changed, 134 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
>> index 4a00806..7261f88 100644
>> --- a/drivers/net/wireless/ath/ath9k/main.c
>> +++ b/drivers/net/wireless/ath/ath9k/main.c
>> @@ -2430,6 +2430,134 @@ static int ath9k_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_ATH9K_DEBUGFS
>
> These are ethtool knobs, so you might want to introduce a new config symbol dedicated to it, which depends on CONFIG_ATH9K_DEBUGFS eventually.

I'd like to gather at least most stats always, so ethtool can work regardless of
debugfs.  But, that can be follow on patches in my opinion.  If it turns out
that we need another config option for this, then that is fine too.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html