lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1332266881.2489.4.camel@bwh-desktop.uk.solarflarecom.com> Date: Tue, 20 Mar 2012 18:08:01 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Mike Sinkovsky <msink@...monline.ru> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] ethernet driver for the WIZnet W5300 chip On Mon, 2012-03-19 at 14:23 +0500, Mike Sinkovsky wrote: > Based on original driver from chip manufacturer, but with many cleanups. > Hope now it is near to mainline kernel quality. > > Tested and used in production with Blackfin BF531 embedded processor. [...] > +static void w5300_get_drvinfo(struct net_device *ndev, > + struct ethtool_drvinfo *info) > +{ > + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > + strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); [...] Nitpick: if you don't have firmware, don't set fw_version at all. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists